efegokdemir commented on code in PR #649:
URL:
https://github.com/apache/commons-configuration/pull/649#discussion_r4154788450
##########
pom.xml:
##########
@@ -48,6 +48,7 @@
org.apache.commons.codec.*;resolution:=optional,
org.apache.commons.jxpath.*;resolution:=optional,
org.apache.xml.resolver.*;resolution:=optional,
+ java.applet.*;resolution:=optional,
Review Comment:
The explicit optional `java.applet` package import is already present in the
current PR diff (alongside the wildcard import), so the base-package resolution
concern is addressed.
##########
pom.xml:
##########
@@ -541,6 +542,35 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>java26</id>
+ <activation>
+ <jdk>[26,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <testExcludes>
+ <testExclude>**/TestAppletConfiguration.java</testExclude>
+ </testExcludes>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/TestWebdavConfigurationBuilder.java</exclude>
+ <exclude>**/TestAppletConfiguration.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
Review Comment:
The PR description already documents the java26 profile and that JDK 26
removes the Applet API and changes test compilation/execution behavior; no
description rewrite was necessary.
##########
pom.xml:
##########
@@ -541,6 +542,35 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>java26</id>
+ <activation>
+ <jdk>[26,)</jdk>
+ </activation>
Review Comment:
Added and pushed in 1c11f0b9: the java26 profile comment explains the
removed Applet API, the TestAppletConfiguration exclusion, the existing
TestWebdavConfigurationBuilder exclusion, and the profile’s intentionally
narrow scope. Maven validation could not run locally because this environment
has no Java or Maven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
