dxbjavid opened a new pull request, #774: URL: https://github.com/apache/commons-text/pull/774
LongestCommonSubsequence.longestCommonSubstringLengthArray dereferences left and right straight away to size the DP array, so passing a null sequence throws a raw NullPointerException out of the public method. Its siblings apply, logestCommonSubsequence and longestCommonSubsequence all guard null and throw IllegalArgumentException, and that behaviour is part of their documented contract, so a caller that catches IllegalArgumentException as the class leads it to expect is instead surprised by an NPE from this one method. Add the same null check and document it so the method lines up with the rest of the class. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Anthropic) helped spot the inconsistency with the sibling methods and draft the guard and the regression tests; I reviewed the change and the test evidence. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
