rootvector2 opened a new pull request, #743:
URL: https://github.com/apache/commons-collections/pull/743
`PrefixRangeEntrySet.EntryIterator.remove()` marks the iteration finished
whenever `lengthInBits >= subtree.bitIndex`, but a subtree root whose
`bitIndex` equals the prefix length in bits is a branch node rather than the
only matching entry (`PrefixRangeEntrySet.iterator()` uses the strict `>` for
that same test and only then returns a `SingletonIterator`), so removing
`andes` from `prefixMap("and")` over the keys `and, andes, android, androids`
ends the iteration after `android` and silently leaves `androids` in the trie,
and `subtree()` returns null once no entry with the prefix is left so the
following `subtree.bitIndex` read throws; found with a randomized differential
test of prefix-view iterator removal against a filtered `TreeMap`, where 200000
random cases give about 3100 `NullPointerException`s, 340 truncated iterations
and 190 tries whose final content differs from the reference before this
change, and 600000 cases are clean after it.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code: it ran the differential test that located the defect
and drafted the patch and the regression test, both of which were reviewed and
verified locally.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
