rootvector2 opened a new pull request, #443: URL: https://github.com/apache/commons-cli/pull/443
`appendOptions` sizes the options column only from the rendered option entries and never from the header row, so once every option is narrower than the `Options` header the gap it computes for the header line, `max - maxSince - HEADER_OPTIONS.length() + leftPad`, is negative and `createPadding` runs `new char[-3]`. With `setShowSince(true)` that makes `printHelp` throw `NegativeArraySizeException` for something as ordinary as an app whose flags are `-h` and `-v`. Found while fuzzing the help output across option widths and pad settings. `determineMaxSinceLength` already floors the since column at the width of the `Since` header; the option column just needs the same floor, so `max` now starts there when `showSince` is set. Keeping the bound next to the arithmetic that uses it leaves every `createPadding` argument in the method non-negative, and output is unchanged for any `Options` whose column was already that wide. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code helped write the fix, the test, and this description. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
