u7924412 opened a new pull request, #1848:
URL: https://github.com/apache/commons-lang/pull/1848
Fixes https://issues.apache.org/jira/browse/LANG-980
DurationFormatUtils.Token compared token values with `==` in two places
(containsTokenWithValue and Token.equals). This only worked because the
values happened to be the same String constant instances. This changes
both
to use equals(). Token values are never null (enforced in the
constructor),
and StringBuilder values keep identity semantics, so existing formatting
behaviour is unchanged.
Added testLANG980, which fails before this change and passes after.
`mvn clean verify` passes locally.
Imports were automatically changed and unable to be reverted, please note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
