u7924412 opened a new pull request, #1853: URL: https://github.com/apache/commons-lang/pull/1853
Fixes [LANG-980](https://issues.apache.org/jira/browse/LANG-980). `DurationFormatUtils.Token` compared token values with `==` in two places: - `Token.containsTokenWithValue(Token[], Object)` - `Token.equals(Object)` This only worked because the values being compared were always the same `String` constant instances (`y`, `M`, `d`, `H`, `m`, `s`, `S`). A token holding an equal but different `String` instance was not recognised, which would cause `formatDuration`/`formatPeriod` to silently leave that unit out. This PR changes both comparisons to use `equals()`, matching how `lexx()` already compares token values (`previous.getValue().equals(value)`). - Token values are never `null` (the constructor uses `Objects.requireNonNull`), so calling `equals()` is safe. - Literal-text tokens hold a `StringBuilder`, which does not override `equals()`, so their behaviour is unchanged. - No public API changes. Added `testLANG980`, which fails before this change and passes after it. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Claude (Anthropic) was used to help investigate the issue, suggest the fix and test, and set up the build. I reviewed, built and tested the change myself. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
