[ 
https://issues.apache.org/jira/browse/MATH-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418576#comment-13418576
 ] 

Gilles commented on MATH-815:
-----------------------------

Personally, I prefer to look at plain Java files, rather than a big "diff" 
file, especially when those files are new and, indeed, subject to be modified 
according to comments given here or on the "dev" ML.

Thanks a lot for your contribution, but there are some issues:
* We aim towards having "immutable" objects:
** When constructing an instance, and when returning instance variables, 
defensive copies must be made.
** No setters: all parameters must be passed through the constructor, and 
assigned (or copied) to "final" instance variables.
** If possible, all instance variables must be "final".
* Inside methods, any constant primitive or object reference (i.e. arrays too) 
should be declared "final".
* Many comments are missing.
* Some variables names are in C-style (e.g. "mean_vector" should become 
"meanVector")
* "@param" comments should start on the same line.
* The utility "print2DArray" should not be included.
* The classes in the "o.a.c.m.distribution" package should not do more than 
represent the given distribution: Computing means and standard deviations of 
data should not be performed in that class.
* Numbers (".5" should be written "0.5").
* Missing "newline" character at the end of the files (i.e. there should be one 
empty line at the end of the source file.

                
> Multivariate Normal Distribution
> --------------------------------
>
>                 Key: MATH-815
>                 URL: https://issues.apache.org/jira/browse/MATH-815
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Jared Becksfort
>            Priority: Minor
>         Attachments: patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> I will submit a class for Multivariate Normal Distributions.  Not sure if it 
> will allow sampling initially.
> > Hello,
> >
> > I have implemented some classes for multivariate Normal distributions, 
> > multivariate normal mixture models, and an expectation maximization fitting 
> > class for the mixture model.  I would like to submit it to Apache Commons 
> > Math.  I still have some touching up to do so that they fit the style 
> > guidelines and implement the correct interfaces.  Before I do so, I thought 
> > I would at least ask if the developers of the project are interested in me 
> > submitting them.
> >
> > Thanks,
> > Jared Becksfort
> Dear Jared,
> Yes, that would be very nice to have such an addition! Remember to also 
> include unit tests (refer to the current ones for examples). The best would 
> be to split a submission up into multiple minor ones, each covering a natural 
> submission (e.g. multivariate Normal distribution in one submission), and 
> create an issue as described at 
> http://commons.apache.org/math/issue-tracking.html .
> If you run into any problems, please do not hesitate to ask on this mailing 
> list.
> Cheers, Mikkel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to