[ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467880#comment-13467880 ]
Luc Maisonobe commented on MATH-811: ------------------------------------ I'll have a more thorough look into it when I have some time. I have thought about that for a while, trying to find a solution as I think this change is important to you. There is one way we could introduce it into 3.1, but it is ugly so I am reluctant to do it. It would imply creating an extended interface (say FilteredSlopeEventHandler extends EventHandler) that would include the new method and to have a runtime check in EventState using instanceof to use the feature only if it is available. What would you think about this ugly hack? > Improve event detection by selecting g function slope > ----------------------------------------------------- > > Key: MATH-811 > URL: https://issues.apache.org/jira/browse/MATH-811 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.1 > Reporter: Yannick TANGUY > Attachments: JIRA-811_slope_selection.patch, > JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_V3.patch, > JIRA-811_slope_selection_V3_with_spaces.patch, > JIRA-811_slope_selection_with_spaces.patch > > > We would like to select g function slope in CommonsMath event detection > feature. > This would improve event detection for the final user (the possibility to > ignore some events, and less computation time) and also correct a bug found > while using OREKIT (see https://www.orekit.org/forge/issues/104) in our > applications. > The modification consists in adding a method (getSlopeSelection() : int) in > EventHandler, and modifying one conditionnal in the method evaluateStep > (class EventState). > We can provide modified code and unitary tests for this feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira