[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468379#comment-13468379
]
Yannick TANGUY commented on MATH-811:
-------------------------------------
Your idea seems interesting, but I think it depends on how users already handle
event detection. If most of them won't use the slope selection, maybe an
extended interface is better, or an abstract class (like in OREKIT events
package), so that these users don't have to implement this method.
But if there are "enough" users who can be interested in the new features, I
think it must be implemented in EventHandler interface, and users will have to
adapt their code.
In the second hypothesis, I understand it will have to wait for 4.0.
Anyway, what's really important for us is to have this feature now (and it's
ok, "our" version of Commons Math implement it), to identify precisely the
differences between our version and the official version (snapshot or a
released version) and then, to know approximatively when this feature could be
integrated (Commons Math roadmap).
By now, this discussion has enabled to improve the implementation, clarify the
use of event detection : that's a good point ! And when you'll have time to
look further into it, we can discuss again to find a more elegant solution (if
any) and integrate it.
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
> Key: MATH-811
> URL: https://issues.apache.org/jira/browse/MATH-811
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Yannick TANGUY
> Attachments: JIRA-811_slope_selection.patch,
> JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_V3.patch,
> JIRA-811_slope_selection_V3_with_spaces.patch,
> JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection
> feature.
> This would improve event detection for the final user (the possibility to
> ignore some events, and less computation time) and also correct a bug found
> while using OREKIT (see https://www.orekit.org/forge/issues/104) in our
> applications.
> The modification consists in adding a method (getSlopeSelection() : int) in
> EventHandler, and modifying one conditionnal in the method evaluateStep
> (class EventState).
> We can provide modified code and unitary tests for this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
