Github user rikles commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/75#discussion_r30460281
  
    --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
    @@ -3277,6 +3277,164 @@ public static String substringBetween(final String 
str, final String open, final
             return list.toArray(new String[list.size()]);
         }
     
    +    /**
    +     * <p>Split a String into an array, using an array of fixed string 
lengths.</p>
    +     *
    +     * <p>If not null String input, the returned array size is same as the 
input lengths array.</p>
    +     *
    +     * <p>A null input String returns {@code null}.
    +     * A {@code null} or empty input lengths array returns an empty array.
    +     * A {@code 0} in the input lengths array results in en empty 
string.</p>
    +     *
    +     * <p>Extra characters are ignored (ie String length greater than sum 
of split lengths).
    +     * All empty substrings other than zero length requested, are returned 
{@code null}.</p>
    +     *
    +     * <pre>
    +     * StringUtils.splitByLength(null, *)      = null
    +     * StringUtils.splitByLength("abc")        = []
    +     * StringUtils.splitByLength("abc", null)  = []
    +     * StringUtils.splitByLength("abc", [])    = []
    +     * StringUtils.splitByLength("", 2, 4, 1)  = [null, null, null]
    --- End diff --
    
    I followed the same logic as in other `StringUtils.split*(...)` methods : 
return `null` if the input string is `null`.
    So `StringUtils.splitByLength(null, *)` return `null`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to