[
https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567602#comment-14567602
]
Gary Gregory commented on DBCP-436:
-----------------------------------
How do you detect if a transaction is active?
> Avoid executing ROLLBACK when transaction is not active
> -------------------------------------------------------
>
> Key: DBCP-436
> URL: https://issues.apache.org/jira/browse/DBCP-436
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: Michael Mikhulya
> Labels: performance
>
> {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on
> the connection as it is returned to the pool.
> It hurts performance.
> I suggest to don't call {{rollback}} if transaction is not active.
> Such improvement is done in HikariCP:
> https://github.com/brettwooldridge/HikariCP/issues/177
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
