[ https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984960#comment-14984960 ]
Mark Thomas commented on DBCP-436: ---------------------------------- Tracking whether or not a transaction is active looks like 'fun'. I agree that the driver is likely to be a much better place to do this. I'm fine with WONT_FIX. > Avoid executing ROLLBACK when transaction is not active > ------------------------------------------------------- > > Key: DBCP-436 > URL: https://issues.apache.org/jira/browse/DBCP-436 > Project: Commons Dbcp > Issue Type: Improvement > Reporter: Michael Mikhulya > Labels: performance > Fix For: 2.2 > > > {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on > the connection as it is returned to the pool. > It hurts performance. > I suggest to don't call {{rollback}} if transaction is not active. > Such improvement is done in HikariCP: > https://github.com/brettwooldridge/HikariCP/issues/177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)