[ https://issues.apache.org/jira/browse/COMPRESS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312024#comment-16312024 ]
Dawid Weiss commented on COMPRESS-380: -------------------------------------- Looks good to me. I thought you'd just return 0 and be done with it, to be honest :) It's nice to see it can be estimated better, but in all honesty I don't think I ever saw {{available}} in any practical use case that made sense. Those times I did see it, it was typically used in the wrong way (code only calling {{read}} when available returned non-zero, etc.). > Support for ENHANCED_DEFLATED (Deflate64) in ZIP files > ------------------------------------------------------ > > Key: COMPRESS-380 > URL: https://issues.apache.org/jira/browse/COMPRESS-380 > Project: Commons Compress > Issue Type: New Feature > Reporter: Dawid Weiss > Fix For: 1.16 > > Attachments: archive-deflate.zip, archive-deflate64.zip, archive.zip, > archive64.zip, compress-380.diff, hello.world, input2 > > > Some of the (large) ZIP files we try to process currently will throw this: > {code} > UnsupportedZipFeatureException: unsupported feature method > 'ENHANCED_DEFLATED' > {code} > which is a bummer since JDK's implementation also doesn't support Deflate64. > This seems to be PKWare's extensions, although code to decrypt it exists in > zlib (and is appropriately licensed, I believe). > https://github.com/madler/zlib/tree/master/contrib/infback9 -- This message was sent by Atlassian JIRA (v6.4.14#64029)