[
https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726983#comment-16726983
]
Matt Juntunen commented on NUMBERS-86:
--------------------------------------
{quote}Please avoid making different kinds of changes (code vs test vs Javadoc)
within the same commit
{quote}
Noted.
{quote}What was the problem with the previous version?
{quote}
The previous version would return quaternions in positive polar form except in
the single situation where the input quaternions have a negative dot product
and {{1}} is passed as the argument to {{apply()}}. In this case, we skip
computation and directly return the end quaternion, which has been negated in
the constructor and is now not in positive polar form. I moved the call to
{{positivePolarForm}} to ensure that the output is always in this form.
> Slerp Unit Tests
> ----------------
>
> Key: NUMBERS-86
> URL: https://issues.apache.org/jira/browse/NUMBERS-86
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{Slerp}} needs unit tests. There are tests in commons-geometry but they rely
> on {{Vector3D}}. We need to port those tests or write new ones.
>
> Pull request: https://github.com/apache/commons-numbers/pull/23
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
