[
https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727206#comment-16727206
]
Matt Juntunen commented on NUMBERS-86:
--------------------------------------
It seems cleaner to me to have the call to {{positivePolarForm}} in a single
location in {{apply}} rather than in 3 separate locations (each algorithm and
the special case for {{end}}). It also seems more self-documenting in terms of
the desired form of the output quaternion. I can change it to the above if
needed, though. It has no effect on the API.
> Slerp Unit Tests
> ----------------
>
> Key: NUMBERS-86
> URL: https://issues.apache.org/jira/browse/NUMBERS-86
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{Slerp}} needs unit tests. There are tests in commons-geometry but they rely
> on {{Vector3D}}. We need to port those tests or write new ones.
>
> Pull request: https://github.com/apache/commons-numbers/pull/23
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
