[ https://issues.apache.org/jira/browse/NUMBERS-90?focusedWorklogId=187873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187873 ]
ASF GitHub Bot logged work on NUMBERS-90: ----------------------------------------- Author: ASF GitHub Bot Created on: 21/Jan/19 19:40 Start Date: 21/Jan/19 19:40 Worklog Time Spent: 10m Work Description: coveralls commented on issue #28: NUMBERS-90: adding DoublePrecisionContext and FloatPrecisionContext URL: https://github.com/apache/commons-numbers/pull/28#issuecomment-455832401 [![Coverage Status](https://coveralls.io/builds/21192664/badge)](https://coveralls.io/builds/21192664) Coverage increased (+0.2%) to 92.985% when pulling **6a6028fe034855daab176177c2b181101362c5c4 on darkma773r:numbers-90** into **2db8cdfdc65326a4a7e86c004c7c147a645944b0 on apache:master**. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 187873) Time Spent: 0.5h (was: 20m) > DoublePrecisionContext > ---------------------- > > Key: NUMBERS-90 > URL: https://issues.apache.org/jira/browse/NUMBERS-90 > Project: Commons Numbers > Issue Type: New Feature > Reporter: Matt Juntunen > Priority: Blocker > Time Spent: 0.5h > Remaining Estimate: 0h > > We should add a new class to commons-numbers-core that encapsulates > configurable strategies for comparing doubles. This is required for > GEOMETRY-11. Here is what I'm picturing: > {code:java} > // abstract class for the general concept of comparisons > public abstract class DoublePrecisionContext implements Comparator<Double> { > public abstract boolean equals(double a, double b); > public int compare(double a, double b) { /* ... */ } > public int compare(Double a, Double b) { /* ... */ } > } > // ... > // concrete class implementing a specific strategy > public class EpsilonUlpDoublePrecisionContext extends DoublePrecisionContext { > public EpsilonUlpDoublePrecisionContext(double eps, double maxUlps) { /* > ... */ } > @Override > public boolean equals(double a, double b) { /* ... */ } > } {code} > Pull request: https://github.com/apache/commons-numbers/pull/28 -- This message was sent by Atlassian JIRA (v7.6.3#76005)