[ https://issues.apache.org/jira/browse/NUMBERS-90?focusedWorklogId=196559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196559 ]
ASF GitHub Bot logged work on NUMBERS-90: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Feb/19 14:25 Start Date: 09/Feb/19 14:25 Worklog Time Spent: 10m Work Description: darkma773r commented on issue #28: NUMBERS-90: adding DoublePrecisionContext and FloatPrecisionContext URL: https://github.com/apache/commons-numbers/pull/28#issuecomment-462048752 I'm closing this PR since this functionality was placed directly in commons-geometry, at least until the API and use cases can be explored more. See GEOMETRY-11. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 196559) > DoublePrecisionContext > ---------------------- > > Key: NUMBERS-90 > URL: https://issues.apache.org/jira/browse/NUMBERS-90 > Project: Commons Numbers > Issue Type: New Feature > Reporter: Matt Juntunen > Priority: Blocker > Time Spent: 40m > Remaining Estimate: 0h > > We should add a new class to commons-numbers-core that encapsulates > configurable strategies for comparing doubles. This is required for > GEOMETRY-11. Here is what I'm picturing: > {code:java} > // abstract class for the general concept of comparisons > public abstract class DoublePrecisionContext implements Comparator<Double> { > public abstract boolean equals(double a, double b); > public int compare(double a, double b) { /* ... */ } > public int compare(Double a, Double b) { /* ... */ } > } > // ... > // concrete class implementing a specific strategy > public class EpsilonUlpDoublePrecisionContext extends DoublePrecisionContext { > public EpsilonUlpDoublePrecisionContext(double eps, double maxUlps) { /* > ... */ } > @Override > public boolean equals(double a, double b) { /* ... */ } > } {code} > Pull request: https://github.com/apache/commons-numbers/pull/28 -- This message was sent by Atlassian JIRA (v7.6.3#76005)