[jira] [Work logged] (IMAGING-151) ColorGroup.color_counts is mutable public List and is multiply sorted

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/IMAGING-151?focusedWorklogId=359888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359888
 ]

ASF GitHub Bot logged work on IMAGING-151:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Dec/19 23:25
            Start Date: 14/Dec/19 23:25
    Worklog Time Spent: 10m 
      Work Description: coveralls commented on issue #64: IMAGING-151: use a 
copy of the list, make members package-protected/private, and re-use Comparator
URL: https://github.com/apache/commons-imaging/pull/64#issuecomment-565762046
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/27618385/badge)](https://coveralls.io/builds/27618385)
   
   Coverage increased (+0.02%) to 74.921% when pulling 
**56e9b2d08651195f999c7516988fc04d6b3cabd4 on kinow:IMAGING-151** into 
**a1072f61f68dcd4f58d171ce576314be7d57101d on apache:master**.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 359888)
    Time Spent: 40m  (was: 0.5h)

> ColorGroup.color_counts is mutable public List and is multiply sorted
> ---------------------------------------------------------------------
>
>                 Key: IMAGING-151
>                 URL: https://issues.apache.org/jira/browse/IMAGING-151
>             Project: Commons Imaging
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha1
>            Reporter: Sebb
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.0-alpha2
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> ColorGroup.color_counts is a public mutable List.
> Also the List is re-sorted in several places
> It looks like the field is only used within the package, so can be package 
> protected.
> However it seems odd that the shared list is re-sorted by
> MedianCutLongestAxisImplementation.doCut
> and
> MedianCutMostPopulatedBoxesImplementation.performNextMedianCut (twice)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)