[ https://issues.apache.org/jira/browse/IMAGING-151?focusedWorklogId=363900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-363900 ]
ASF GitHub Bot logged work on IMAGING-151: ------------------------------------------ Author: ASF GitHub Bot Created on: 27/Dec/19 09:06 Start Date: 27/Dec/19 09:06 Worklog Time Spent: 10m Work Description: kinow commented on pull request #64: IMAGING-151: use a copy of the list, make members package-protected/private, and re-use Comparator URL: https://github.com/apache/commons-imaging/pull/64 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 363900) Time Spent: 50m (was: 40m) > ColorGroup.color_counts is mutable public List and is multiply sorted > --------------------------------------------------------------------- > > Key: IMAGING-151 > URL: https://issues.apache.org/jira/browse/IMAGING-151 > Project: Commons Imaging > Issue Type: Bug > Affects Versions: 1.0-alpha1 > Reporter: Sebb > Assignee: Bruno P. Kinoshita > Priority: Major > Fix For: 1.0-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > ColorGroup.color_counts is a public mutable List. > Also the List is re-sorted in several places > It looks like the field is only used within the package, so can be package > protected. > However it seems odd that the shared list is re-sorted by > MedianCutLongestAxisImplementation.doCut > and > MedianCutMostPopulatedBoxesImplementation.performNextMedianCut (twice) -- This message was sent by Atlassian Jira (v8.3.4#803005)