[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=466717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466717
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/20 10:16
Start Date: 05/Aug/20 10:16
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #118:
URL: https://github.com/apache/commons-io/pull/118#discussion_r465622006
##########
File path: src/test/java/org/apache/commons/io/IOUtilsTestCase.java
##########
@@ -311,28 +314,38 @@ public synchronized void close() throws IOException {
assertTrue(IOUtils.contentEqualsIgnoreEOL(input1, input1));
}
- Reader r1;
- Reader r2;
-
- r1 = new CharArrayReader("".toCharArray());
- r2 = new CharArrayReader("".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("1".toCharArray());
- r2 = new CharArrayReader("1".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("1".toCharArray());
- r2 = new CharArrayReader("2".toCharArray());
- assertFalse(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("123\rabc".toCharArray());
- r2 = new CharArrayReader("123\nabc".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("321".toCharArray());
- r2 = new CharArrayReader("321\r\n".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
+ testSingleEOL("", "", true);
+ testSingleEOL("", "\n", true);
+ testSingleEOL("", "\r", true);
+ testSingleEOL("", "\r\n", true);
+ testSingleEOL("", "\r\r", false);
+ testSingleEOL("", "\n\n", false);
+ testSingleEOL("1", "1", true);
+ testSingleEOL("1", "2", false);
+ testSingleEOL("123\rabc", "123\nabc", true);
+ testSingleEOL("321", "321\r\n", true);
+ testSingleEOL("321", "321\r\naabb", false);
+ testSingleEOL("321", "321\n", true);
+ testSingleEOL("321", "321\r", true);
+ testSingleEOL("321", "321\r\n", true);
+ testSingleEOL("321", "321\r\r", false);
+ testSingleEOL("321", "321\n\r", false);
+ testSingleEOL("321\n", "321", true);
+ testSingleEOL("321\n", "321\n\r", false);
+ testSingleEOL("321\n", "321\r\n", true);
+ testSingleEOL("321\r", "321\r\n", true);
+ testSingleEOL("321\r\n", "321\r\n\r", false);
+ testSingleEOL("123", "1234", false);
+ }
+
Review comment:
@sebbASF OK, I will create a new pr for the changes IOUtilsTestCase.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 466717)
Time Spent: 9h 20m (was: 9h 10m)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
