[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=466751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466751
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/20 11:43
Start Date: 05/Aug/20 11:43
Worklog Time Spent: 10m
Work Description: XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669143244
@sebbASF
> AFAICT the new classes UnsyncBufferedReader etc are not actually used
(except in test code).
yes, they are not quite used, but used for being parent class of
LineEndUnifiedBufferedReader
I also have a plan to use them insteadof BufferedReader in some other places
in this repo.
But this pr is already large, and I don't think it good to change too much
more things.
> I would expect all the contentEquals methods to remain exactly the same
except for changes to the input sources.
> The logic should remain unchanged (otherwise the new classes are not
proper replacements).
It can, but have huge performance lost.
I also used another trick in those contentEquals functions, which cannot be
used if we use that classes.
And if we use the two classes there, will be 1 time slower than the
functions we used in this pr (still be about 2 times faster than original)
> Likewise I would not expect to see any changes to test cases, only new
ones for the new classes, and perhaps a few new samples for existing methods
where the coverage is incomplete.
The changes in test are already moved to another pr, at
https://github.com/apache/commons-io/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 466751)
Time Spent: 11h (was: 10h 50m)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 11h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
