[jira] [Work logged] (LANG-1631) Check if the char to be searched is defined

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/LANG-1631?focusedWorklogId=527256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527256
 ]

ASF GitHub Bot logged work on LANG-1631:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Dec/20 16:11
            Start Date: 22/Dec/20 16:11
    Worklog Time Spent: 10m 
      Work Description: arturobernalg commented on a change in pull request 
#682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547365219



##########
File path: 
src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
##########
@@ -506,42 +510,57 @@ public void testIndexOfIgnoreCase_StringInt() {
         assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 2));
         assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 3));
         assertEquals(4, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 4));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 5));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 6));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 7));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("aabaabaa", "AB", 8));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", 
"AB", 5));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", 
"AB", 6));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", 
"AB", 7));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aabaabaa", 
"AB", 8));
         assertEquals(1, StringUtils.indexOfIgnoreCase("aab", "AB", 1));
         assertEquals(5, StringUtils.indexOfIgnoreCase("aabaabaa", "", 5));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("aab", "AAB", 1));
-        assertEquals(-1, StringUtils.indexOfIgnoreCase("abc", "", 9));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("ab", "AAB", 0));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("aab", "AAB", 
1));
+        assertEquals(NOT_FOUND, StringUtils.indexOfIgnoreCase("abc", "", 9));
     }
 
     @Test
     public void testLastIndexOf_char() {
-        assertEquals(-1, StringUtils.lastIndexOf(null, ' '));
-        assertEquals(-1, StringUtils.lastIndexOf("", ' '));
+        assertEquals(NOT_FOUND, StringUtils.lastIndexOf(null, ' '));
+        assertEquals(NOT_FOUND, StringUtils.lastIndexOf("", ' '));
         assertEquals(7, StringUtils.lastIndexOf("aabaabaa", 'a'));
         assertEquals(5, StringUtils.lastIndexOf("aabaabaa", 'b'));
 
         assertEquals(5, StringUtils.lastIndexOf(new StringBuilder("aabaabaa"), 
'b'));
+        char[] charArray = new char[9];
+        charArray[0] = '[';
+        charArray[1] = '&';
+        charArray[7] = '{';
+        charArray[3] = '.';
+        charArray[4] = 'c';
+        charArray[5] = '.';
+        charArray[6] = '0';
+        charArray[7] = 'r';
+        charArray[8] = 'o';
+        CharBuffer charBuffer = CharBuffer.wrap(charArray);
+        assertEquals(NOT_FOUND, StringUtils.lastIndexOf (charBuffer, (-1738), 
982));

Review comment:
       HI @garydgregory 
   sorry for the noise. When I created the PR it seemed logical.  But you're 
right. Better keep the PRs separate




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 527256)
    Time Spent: 40m  (was: 0.5h)

> Check if the char to be searched is defined
> -------------------------------------------
>
>                 Key: LANG-1631
>                 URL: https://issues.apache.org/jira/browse/LANG-1631
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Arturo Bernal
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
>  
> Crash when the the char to be searched value it's out of range >=  '\u0000' 
> <= '\uFFFF'
>  Getting the next error -->
>  
> {code:java}
> java.lang.IllegalArgumentException: Not a valid Unicode code point: 
> 0xFFFFF936{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)