[
https://issues.apache.org/jira/browse/LANG-1631?focusedWorklogId=527372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527372
]
ASF GitHub Bot logged work on LANG-1631:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 21:22
Start Date: 22/Dec/20 21:22
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#682:
URL: https://github.com/apache/commons-lang/pull/682#discussion_r547511368
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -109,6 +109,7 @@ static int indexOf(final CharSequence cs, final int
searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
idem @garydgregory
##########
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##########
@@ -195,6 +196,7 @@ static int lastIndexOf(final CharSequence cs, final int
searchChar, int start) {
return i;
}
}
+ return NOT_FOUND;
Review comment:
mm . Maybe it's my fault.
The idea it's exit the loop and return -1 (NOT_FOUND) if not found the
charset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 527372)
Time Spent: 2h 10m (was: 2h)
> Check if the char to be searched is defined
> -------------------------------------------
>
> Key: LANG-1631
> URL: https://issues.apache.org/jira/browse/LANG-1631
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
>
> Crash when the the char to be searched value it's out of range >= '\u0000'
> <= '\uFFFF'
> Getting the next error -->
>
> {code:java}
> java.lang.IllegalArgumentException: Not a valid Unicode code point:
> 0xFFFFF936{code}
>
>
> Basically the problem is that when it is verified that the character to
> search is less than MIN_SUPPLEMENTARY_CODE_POINT, the search is not exited of
> the loop. It continues searching but this time values less than or equal to
> Character.MAX_CODE_POINT
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
