garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571033303



##########
File path: 
src/main/java/org/apache/commons/daemon/support/DaemonConfiguration.java
##########
@@ -62,6 +62,11 @@
     private final Properties configurationProperties;
     private final Properties systemProperties;
 
+    /**
+     * An empty immutable {@code String} array.
+     */

Review comment:
       This does not need to be public. You could define ONE constant to be 
package private and reuse it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to