garydgregory commented on a change in pull request #22:
URL: https://github.com/apache/commons-daemon/pull/22#discussion_r571192372
##########
File path: src/test/java/org/apache/commons/daemon/SimpleDaemon.java
##########
@@ -28,18 +28,18 @@
*/
public class SimpleDaemon implements Daemon, Runnable, DaemonUserSignal {
- private ServerSocket server=null;
- private Thread thread=null;
- private DaemonController controller=null;
- private volatile boolean stopping=false;
- private String directory=null;
- private Vector<Handler> handlers=null;
+ private ServerSocket server;
+ private Thread thread;
+ private DaemonController controller;
+ private volatile boolean stopping;
+ private String directory;
+ private final Vector<Handler> HANDLERS;
private boolean softReloadSignalled;
public SimpleDaemon() {
System.err.println("SimpleDaemon: instance "+this.hashCode()+
" created");
- this.handlers=new Vector<Handler>();
+ this.HANDLERS =new Vector<Handler>();
Review comment:
Why is this upper case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
