erisu commented on code in PR #1606:
URL: https://github.com/apache/cordova-android/pull/1606#discussion_r1174349278
##########
lib/build.js:
##########
@@ -58,7 +63,8 @@ function parseOpts (options, resolvedTarget, projectRoot) {
if (options.argv.maxSdkVersion) { ret.extraArgs.push('-PcdvMaxSdkVersion='
+ options.argv.maxSdkVersion); }
if (options.argv.targetSdkVersion) {
ret.extraArgs.push('-PcdvTargetSdkVersion=' + options.argv.targetSdkVersion); }
if (options.argv.gradleArg) {
- ret.extraArgs = ret.extraArgs.concat(options.argv.gradleArg);
+ const gradleArgs =
ARGVParser.parseArgsStringToArgv(options.argv.gradleArg[0]);
Review Comment:
```suggestion
const gradleArgs = parseArgsStringToArgv(options.argv.gradleArg[0]);
```
##########
lib/build.js:
##########
@@ -21,6 +21,7 @@ const path = require('path');
const fs = require('fs');
const nopt = require('nopt');
const untildify = require('untildify');
+const ARGVParser = require('string-argv');
Review Comment:
```suggestion
const { parseArgsStringToArgv } = require('string-argv');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
