breautek commented on PR #1606: URL: https://github.com/apache/cordova-android/pull/1606#issuecomment-1518705716
> This looks okay to me. > > It would maybe be good to have a test case that covered the splitting of `gradleArgs` into multiple `extraArgs` tokens. I added a new `build.spec.js` unit test file since gradle argument parsing happens earlier than what `ProjectBuilder.spec.js` tests. I only added testing that was relevant in the PR but could probably be expanded further to match more closely to what `run.spec.js` does. Added series of different test cases regarding using the `--gradleArg` flag and testing the parsed argv array, which would include the usage of `nopt` + `string-argv` third-party dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
