breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2103230938
> It's not regarding licensing per se, it's under the [source packages policy](https://www.apache.org/legal/release-policy.html#source-packages): > > > ### Source packages > > Every ASF release MUST contain one or more source packages, which MUST be sufficient for a user to build and test the release provided they have access to the appropriate platform and tools. A source release SHOULD not contain compiled code. > > That last line in particular. > > With that said, I looked and see several other ASF projects with gradle wrappers committed to their repositories, so I don't think I have any actual objection to this. I believe another section allows it given certain requirements: https://www.apache.org/legal/release-policy.html#distribute-other-artifacts >ASF releases typically contain additional material together with the source package. This material may include documentation concerning the release but must contain LICENSE and NOTICE files. As mentioned above, these artifacts must be signed by a committer with a detached signature if they are to be placed in the project's distribution directory. > >Again, these artifacts may be distributed only if they contain LICENSE and NOTICE files. For example, the Java artifact format is based on a compressed directory structure and those projects wishing to distribute jars must place LICENSE and NOTICE files in the META-INF directory within the jar. I unpacked the wrapper jar file and found that they have their own license file, but does lack a NOTICE file. At the end of the day, the contents is still going to be signed, comes from a trusted source, assuming it gets updated via gradle tooling and the jar is a build tool dependency, it isn't part of the apache source code. But I understand how that could tie into the "provided they have access to the appropriate platform and tools." In legal terms they also used `SHOULD` instead of `MUST` or `SHALL`. "Should" is more of a suggestion rather than mandatory whereas "must" or "shall" is mandatory terms. Therefore including compiled code should be a thoughtful process (like this one). It shouldn't be made a habit, it should only be done when it's truly necessary. I think the gradle wrapper fits all of those ticks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
