[ https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288204#comment-14288204 ]
ASF GitHub Bot commented on CB-8239: ------------------------------------ Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23408933 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -423,7 +420,7 @@ function platform(command, targets, opts) { // Neither path, nor platform name - throw. var msg; if (/[~:/\\.]/.test(t)) { - msg = 'Platform path "' + t + '" not found.'; + return; --- End diff -- This needs a code comment saying what's going on in this case. > Add support for git urls to 'cordova platform add' > -------------------------------------------------- > > Key: CB-8239 > URL: https://issues.apache.org/jira/browse/CB-8239 > Project: Apache Cordova > Issue Type: New Feature > Components: CLI, CordovaLib > Reporter: Omar Mefire > > Allow the following scenarios: > - users can issue 'cordova platform add > https://github.com/apache/cordova-android.git' and the git repo will be > cloned and used. > - users can issue 'cordova platform add > android@https://github.com/apache/cordova-android.git' and the git repo will > be cloned and used. > - users can issue 'cordova platform add android' and if their config.xml file > contains: '<engine id='android' > version='https://github.com/apache/cordova-android.git' />, then the git repo > pointed to by config.xml will be cloned and used. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org