[ 
https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288208#comment-14288208
 ] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23409016
  
    --- Diff: cordova-lib/src/cordova/util.js ---
    @@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath, 
opt_wrap, opt_obj) {
             });
         }
     }
    +
    +function resolvePath(pPath) {
    --- End diff --
    
    Extracting this as a helper just makes the code harder to follow.


> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add 
> https://github.com/apache/cordova-android.git' and the git repo will be 
> cloned and used.
> - users can issue 'cordova platform add 
> android@https://github.com/apache/cordova-android.git' and the git repo will 
> be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file 
> contains: '<engine id='android' 
> version='https://github.com/apache/cordova-android.git' />, then the git repo 
> pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to