[
https://issues.apache.org/jira/browse/CB-8510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336548#comment-14336548
]
ASF subversion and git services commented on CB-8510:
-----------------------------------------------------
Commit 087ec11e6abc61acde4e2860f8ee363f3daba578 in cordova-android's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=087ec11 ]
CB-8510 Create a new abstraction for sharing common logic of WebView engines
Having CordovaWebViewImpl separate from CordovaWebViewEngine is helpful because
now each webview doesn't have to re-implement non-webview-specific
featrues. e.g.:
1. load timeout
2. keyboard events
3. showCustomView
4. lifecycle events
Moved AndroidWebView into its own package to ensure that it doesn't use
any package-private symbols (since plugins cannot use them).
> Delete copy&paste between AndroidWebView and XWalkWebView
> ---------------------------------------------------------
>
> Key: CB-8510
> URL: https://issues.apache.org/jira/browse/CB-8510
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Andrew Grieve
> Assignee: Andrew Grieve
>
> Right now there is a lot of copy & paste between the two, and bugs that have
> been fixed on master have not all made it into XWalkWebView. Copy & paste was
> a great way to get the concept off the ground, but it would be vastly more
> maintainable to have it shared in some way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
