[
https://issues.apache.org/jira/browse/CB-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381903#comment-14381903
]
ASF GitHub Bot commented on CB-8753:
------------------------------------
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-86521912
Great questions.
The statics are meant to prevent multiple splash screens from showing if
there is more than one CordovaWebView within a project.
`CordovaPreferences.copyIntoIntentExtras(Activity)` - it's legacy.
keep getting preferences from CordovaPreferences - because embedders can
change these preferences during app start-up, and we want those changes to take
effect.
New Prefs android only - yes. that's fine. Splash screen already has mostly
platform-specific prefs :(
Overall comments:
- Randomly, an `onConfigurationChange` hook was just recently added to
master, so you should just use that instead.
- We aren't planning on doing another release of 3.x branch, so you should
make these changes to cordova-plugin-splashscreen, which is what will work with
cordova-android@4.0.x (and with master branch of cordova-android)
- I don't see why anyone would want reloadOnOrientationChange=false, so
maybe don't make that a preference?
- Might be better to get rid of the LinearLayout, and instead switch to an
ImageView in both cases
> Maintain splash screen aspect ratio
> -----------------------------------
>
> Key: CB-8753
> URL: https://issues.apache.org/jira/browse/CB-8753
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: 3.7.1
> Environment: Android
> Reporter: Alex Talis
> Fix For: 3.8.0, 4.0.0, 3.7.1
>
> Attachments: cur-land.png, cur-port.png, new-land.png, new-port.png
>
>
> I will be submitting a pull request for this enhancement shortly.
> Current splash screen scales images non-uniformly to fit into splash dialog.
> This approach does not work well for many typical splash screen images that
> contain scenery or text and look bad when aspect ratio is not preserved.
> 9-patch images work, but they have to be carefully designed so that the edges
> can be stretched without producing undesired effects.
> The purpose of this enhancement is to allow use of non-9-patch images without
> stretching, similar to CSS "background-size:cover" capability. For this to
> work, splash images have to have large safe area all around that can be
> safely cropped off.
> With this type of splash screen, it is usually necessary to use different
> images for portrait and landscape orientations, so a second part of this
> enhancement is to add an option to reload the drawable when orientation
> changes.
> Examples of the two preferences are shown below. Both are optional and
> default to False to maintain current splash screen behavior.
> <preference name="SplashMaintainAspectRatio" value="true"/>
> <preference name="SplashReloadOnOrientationChange" value="true"/>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
