[
https://issues.apache.org/jira/browse/CB-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384608#comment-14384608
]
ASF GitHub Bot commented on CB-8753:
------------------------------------
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-87086720
It doesn't work for me on Windows, probably because my repo structure is
totally different from what you use. I'm not going to bug you with more
questions - it's not that big of a deal. I can manually create the link.
From: agrieve <notificati...@github.com>
To: apache/cordova-android <cordova-andr...@noreply.github.com>
Cc: Alex <alex.ta...@yahoo.com>
Sent: Friday, March 27, 2015 1:18 PM
Subject: Re: [cordova-android] CB-8753 Maintain splash screen aspect ratio
(#168)
Install the plugin with the --link flag, and then you should be able to
edit it in the projects and the changes will be reflected in the repo (it
creates symlinks)—
Reply to this email directly or view it on GitHub.
> Maintain splash screen aspect ratio
> -----------------------------------
>
> Key: CB-8753
> URL: https://issues.apache.org/jira/browse/CB-8753
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: 3.7.1
> Environment: Android
> Reporter: Alex Talis
> Fix For: 3.8.0, 4.0.0, 3.7.1
>
> Attachments: cur-land.png, cur-port.png, new-land.png, new-port.png
>
>
> I will be submitting a pull request for this enhancement shortly.
> Current splash screen scales images non-uniformly to fit into splash dialog.
> This approach does not work well for many typical splash screen images that
> contain scenery or text and look bad when aspect ratio is not preserved.
> 9-patch images may work, but they have to be carefully designed so that the
> inside can be stretched without distorting important information.
> The purpose of this enhancement is to allow use of non-9-patch images without
> stretching, similar to CSS "background-size:cover" capability. For this to
> work, splash images have to have large safe area all around that can be
> safely cropped off.
> With this type of splash screen, it is usually necessary to use different
> images for portrait and landscape orientations, so a second part of this
> enhancement is to add an option to reload the drawable when orientation
> changes.
> Examples of the two preferences are shown below. Both are optional and
> default to False to maintain current splash screen behavior.
> <preference name="SplashMaintainAspectRatio" value="true"/>
> <preference name="SplashReloadOnOrientationChange" value="true"/>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
