[
https://issues.apache.org/jira/browse/CB-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147441#comment-15147441
]
ASF GitHub Bot commented on CB-10618:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/259
CB-10618 Handle gradle frameworks on plugin installation/uninstallation
An implementation for
[CB-10618](https://issues.apache.org/jira/browse/CB-10618)
This PR brings into platform logic for processing gradle files after plugin
installation (instead of keeping it in LIB).
It also removes `prepBuildFiles` method from `build` module exports, and by
this disables this logic being called from LIB (as there is a check for
`build.prepBuildFiles` existence - see
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L625)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-10618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 673150ccde2fcc8f7c4305d6f51dc24341330cf5
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date: 2016-02-15T13:18:44Z
CB-10618 Handle gradle frameworks on plugin installation/uninstallation
----
> A logic for gradle frameworks processing should be in platform instead of LIB
> -----------------------------------------------------------------------------
>
> Key: CB-10618
> URL: https://issues.apache.org/jira/browse/CB-10618
> Project: Apache Cordova
> Issue Type: Task
> Components: Android, CordovaLib
> Affects Versions: 5.2.0, 6.0.1
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> After each plugin installtion/uninstallation LIB calls
> {{build.prepBuildFiles()}} from android platform. However, since this is
> platform-specific logic, this should be something that happens inside
> addPlugin() function in cordova-android Api.js
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
