[ 
https://issues.apache.org/jira/browse/CB-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147449#comment-15147449
 ] 

ASF GitHub Bot commented on CB-10618:
-------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/389

    CB-10618 Do not call prepBuildFiles for cordova-android@>=5.2.0

    An implementation for 
[CB-10618](https://issues.apache.org/jira/browse/CB-10618)
    This PR disables calling `prepBuildFiles` as since android@5.2.0 it is 
called from platform's code

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-10618

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
    
----

----


> A logic for gradle frameworks processing should be in platform instead of LIB
> -----------------------------------------------------------------------------
>
>                 Key: CB-10618
>                 URL: https://issues.apache.org/jira/browse/CB-10618
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Android, CordovaLib
>    Affects Versions: 5.2.0, 6.0.1
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> After each plugin installtion/uninstallation LIB calls 
> {{build.prepBuildFiles()}} from android platform. However, since this is 
> platform-specific logic, this should be something that happens inside 
> addPlugin() function in cordova-android Api.js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to