[ https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265013#comment-15265013 ]
ASF GitHub Bot commented on CB-11023: ------------------------------------- Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464 @ktop @riknoll yeah, config.xml should be part of this. Anything in config.xml should trump whatever is specified in the plugin.xml. If we do modes then default mode would be `add`, if nothing to `replace` then it becomes an `add` and `delete` could take out the entire element. We can work on flags later but getting attribute level manipulation into config.xml and plugin.xml parsing would be amazing. @purplecabbage you need to add: ``` <config-file target="AndroidManifest.xml" parent="/manifest" attr="true"> <application android:name="MyApplication" android:isGame="true" /> <uses-sdk android:maxSdkVersion="22" /> </config-file> ``` into the plugin.xml of a plugin you are including in the project. So... ``` cordova create newproject cordova platform add android cordova plugin add cordova-plugin-one-I-just-made-up // modified the plugin.xml with the fragment from above cordova prepare // checked androidmanifest.xml for changes ``` > plugin.xml should be able to add attribute to an existing element in > AndroidManifest.xml > ---------------------------------------------------------------------------------------- > > Key: CB-11023 > URL: https://issues.apache.org/jira/browse/CB-11023 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman > Reporter: Carlos Santana > > We have a need for a plugin we develop to add the attribute android:name to > the <application> element to be able to point to a Class that tracks app > sessions for analytics. > plugin.xml only support via <config-file> only to add elements to > AndroidManfist.xml this request is to add an enhancement to also handle > adding an attribute to an existing element. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org