[ 
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272738#comment-15272738
 ] 

ASF GitHub Bot commented on CB-11023:
-------------------------------------

Github user macdonst commented on the pull request:

    https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255
  
    @ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once 
I did I was able to get your code to run. It seems to be working pretty good to 
me. So I would love to get this into cordova ASAP.
    
    Folks do you think we should merge this PR then look at changes to 
config.xml or land it all in one PR?


> plugin.xml should be able to add attribute to an existing element in 
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-11023
>                 URL: https://issues.apache.org/jira/browse/CB-11023
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, Plugman
>            Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to 
> the <application> element to be able to point to a Class that tracks app 
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to 
> AndroidManfist.xml this request is to add an enhancement to also handle 
> adding an attribute to an existing element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to