[ 
https://issues.apache.org/jira/browse/CB-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884874#comment-15884874
 ] 

ASF GitHub Bot commented on CB-10879:
-------------------------------------

GitHub user Lazza opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/77

    CB-10879: (android) Enable overlaysWebView on Android API 21+

    ### Platforms affected
    
    Android (API 21+).
    
    ### What does this PR do?
    
    This patch enables devices running Android API 21+ to have the status bar 
overlaying the WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any 
Android version call `StatusBar.overlaysWebView(false)` to disable the overlay, 
which is actually the default behavior on that platform.
    
    ### What testing has been done on this change?
    
    It has been tested on emulators running several android versions, both 
before and after API 21.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lazza/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit de4c0efa3a763807f9fbbf128ac165d2a43eb538
Author: Andrea Lazzarotto <andrea.lazzaro...@gmail.com>
Date:   2017-02-26T19:11:07Z

    Enable overlaysWebView on Android API 21+
    
    This patch enables devices running Android API 21+ to have the status bar 
overlaying the WebView, i.e. `StatusBar.overlaysWebView(true)`. It lets any 
Android version call `StatusBar.overlaysWebView(false)` to disable the overlay, 
which is actually the default behavior on that platform.

----


> Support transparent status bar for Android
> ------------------------------------------
>
>                 Key: CB-10879
>                 URL: https://issues.apache.org/jira/browse/CB-10879
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Statusbar
>         Environment: Android
>            Reporter: Ray Shan
>            Priority: Minor
>              Labels: Android
>
> Continuation of discussion here: 
> https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76480150
> Seems like Android officially endorses transparent status bar now:
> http://android-developers.blogspot.com/2015/05/android-design-support-library.html
> Example implementation:
> https://github.com/ekuwang/cordova-plugin-statusbar
> Would be nice to have this capability in the official plugin. Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to