[ 
https://issues.apache.org/jira/browse/CB-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885425#comment-15885425
 ] 

ASF GitHub Bot commented on CB-10879:
-------------------------------------

Github user Lazza commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103163253
  
    --- Diff: src/android/StatusBar.java ---
    @@ -142,6 +142,23 @@ public void run() {
                 return true;
             }
     
    +        if ("overlaysWebView".equals(action)) {
    +            if (Build.VERSION.SDK_INT >= 21) {
    --- End diff --
    
    This one is used to check the return value of the method, the one on line 
186 is used to isolate API 21+ code, so that the compiler handles it correctly 
and doesn't complain about it when building for older versions of Android.


> Support transparent status bar for Android
> ------------------------------------------
>
>                 Key: CB-10879
>                 URL: https://issues.apache.org/jira/browse/CB-10879
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Statusbar
>         Environment: Android
>            Reporter: Ray Shan
>            Priority: Minor
>              Labels: Android
>
> Continuation of discussion here: 
> https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76480150
> Seems like Android officially endorses transparent status bar now:
> http://android-developers.blogspot.com/2015/05/android-design-support-library.html
> Example implementation:
> https://github.com/ekuwang/cordova-plugin-statusbar
> Would be nice to have this capability in the official plugin. Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to