[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085978#comment-16085978 ]
ASF GitHub Bot commented on CB-12895: ------------------------------------- GitHub user audreyso opened a pull request: https://github.com/apache/cordova-ios/pull/327 CB-12895: replaced jshint with eslint <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-ios CB-12895-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #327 ---- commit f9b046e5fae2f83c7aa9bf20d80a1fcfd09d05f9 Author: Audrey So <audre...@apache.org> Date: 2017-06-15T17:56:59Z CB-12895 : removed jshint and added eslint commit b7b92263af52efd2bad27d5bdba63ee24244e76a Author: Audrey So <audre...@apache.org> Date: 2017-06-15T18:02:03Z CB-12895 : formatted using eslint rules commit d2fae43e99f2f4da52d3aa13aee309c805964eea Author: Audrey So <audre...@apache.org> Date: 2017-07-12T21:47:46Z CB-12895 : updated indenting with eslint rules ---- > Replace jshint with eslint in our tools + platforms > --------------------------------------------------- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents > Reporter: Steve Gill > Assignee: Audrey So > Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org