[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086277#comment-16086277 ]
ASF GitHub Bot commented on CB-12895: ------------------------------------- Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/327 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=h1) Report > Merging [#327](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `52.39%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/327/graphs/tree.svg?height=150&width=650&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #327 +/- ## ========================================== + Coverage 63.77% 63.91% +0.14% ========================================== Files 14 14 Lines 1623 1671 +48 Branches 277 277 ========================================== + Hits 1035 1068 +33 - Misses 588 603 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...mplates/scripts/cordova/lib/copy-www-build-step.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NvcHktd3d3LWJ1aWxkLXN0ZXAuanM=) | `0% <0%> (ø)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/clean.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NsZWFuLmpz) | `0% <0%> (ø)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.66% <100%> (+0.06%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz) | `100% <100%> (ø)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==) | `25.61% <17.8%> (+3.2%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `38.77% <19.78%> (+1.93%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `12.35% <27.58%> (+0.45%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `42.04% <36.11%> (+2.04%)` | :arrow_up: | | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `53.89% <42.85%> (ø)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `76.85% <60.41%> (+1.2%)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=footer). Last update [26beb94...80f4521](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Replace jshint with eslint in our tools + platforms > --------------------------------------------------- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents > Reporter: Steve Gill > Assignee: Audrey So > Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org