[
https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365676#comment-16365676
]
ASF GitHub Bot commented on CB-13877:
-------------------------------------
janpio opened a new pull request #259: [WIP] CB-13877 Clean up MSBuildTools.js
URL: https://github.com/apache/cordova-windows/pull/259
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MSBuildTools selection is a mess
> --------------------------------
>
> Key: CB-13877
> URL: https://issues.apache.org/jira/browse/CB-13877
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> Now with VS2017 out, the code for the detection of the correct MSBuildTools
> installation is a total mess and works just by accident.
> Things to do:
> - -Give more output that can help understand what is going on- Done via PR 255
> - Give more ways to influence the selection
> - -Integrate new restrictions like no Win8.1 support with VS2017-only
> installations- Acceptable limitation for a dead platform I think
> - Simplify selection code that is currently spread over 2 files:
> `MSBuildTools.js` and `build.js`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
