[
https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365712#comment-16365712
]
ASF subversion and git services commented on CB-13877:
------------------------------------------------------
Commit aed7484098b15827e4947762402345e2df3f7299 in cordova-windows's branch
refs/heads/master from Jan Piotrowski
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=aed7484 ]
CB-13877 Clean up MSBuildTools.js (#259)
* comments in MSBuildTools.js
* move method
* temporary logging
* clearer comment
* move method
* move filterSupportedTargets from build.js to MSBuildTools.js
* restructure getLatestMSBuild to get the list of available MSBuilds itself
restructure usage of MSBuildTools in build.js to that new reality (get
builtTargets earlier, get msBuild instead of list, use both to filter
buildTargets earlier)
* now also remove filterSupportedTargets from build.js
* move method
* fix eslint
* Visual Studio 15.5 is a thing the script should know about
* better logging for checkMSBuildVersion
future method preparation
* fix eslint
* disable some unit tests
* move filterSupportedTargets into getLatestMatchingMSBuild
* move method
* switch Error to CordovaError
* fix comments
* re-enable tests (but 3)
* fix eslint
* TODO comment for future functionality
* document ugly hack for VS17 MSBuild selection
* undo VS17 stuff
> MSBuildTools selection is a mess
> --------------------------------
>
> Key: CB-13877
> URL: https://issues.apache.org/jira/browse/CB-13877
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> Now with VS2017 out, the code for the detection of the correct MSBuildTools
> installation is a total mess and works just by accident.
> Things to do:
> - -Give more output that can help understand what is going on- Done via PR 255
> - Give more ways to understand selection
> - -Integrate new restrictions like no Win8.1 support with VS2017-only
> installations- Acceptable limitation for a dead platform I think
> - Simplify selection code that is currently spread over 2 files:
> `MSBuildTools.js` and `build.js`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
