[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518767#comment-16518767 ]
ASF GitHub Bot commented on CB-13685: ------------------------------------- Menardi commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398943023 This PR looks good to me. I need adaptive icons for one of my own apps, so I'm eager to see this get merged soon. Without support for this, icons for apps using `cordova-android@7` (targeting API 26+) look a bit rubbish on newer devices. I noticed the main cordova-android maintainer, Joe, has announced on the mailing list that he is stepping down. So, I expect that getting this thoroughly reviewed is now more difficult. If there is anything I can do to get this over the line, please let me know. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > ---------------------- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All > Reporter: Josef Brandl > Assignee: Joe Bowser > Priority: Minor > > Starting with Android 8 Oreo (API level 26) Android allows developers to > create app icons using a background and a foreground image file. This feature > is called "adaptive icons". One major change that goes with this feature is > that icons get now clipped into a shape by the system. This leads to a very > uniform and clean design like on iOS where all icons are a rounded rectangle. > The other advantage is that visual effects can be applied to the icon by the > system due to the separation between foreground an background. > Android Studio greatly assists the developer at the creation of the app icon > resources because it creates backwards compatible icons for older devices > that don't support the adaptive icons feature. > https://developer.android.com/studio/write/image-asset-studio.html > The following resources are created. > {code} > res > ├── drawable > │ ├── ic_launcher_background.xml > │ └── ic_launcher_foreground.xml > ├── mipmap-anydpi-v26 > │ ├── ic_launcher.xml > │ └── ic_launcher_round.xml > ├── mipmap-hdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-mdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xxhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > └── mipmap-xxxhdpi > ├── ic_launcher.png > └── ic_launcher_round.png > {code} > It is currently not clear how these files can be used inside a cordova > project. > - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources > (foreground, background) > - The foreground and background can be vector graphics (-> xml files in > res/drawable) > - The documentation needs to be updated > (I've never reported an issue using JIRA before - I'm only used to github. > So, please guide me if I'm doing something incorrect) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org