[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519065#comment-16519065
]
ASF GitHub Bot commented on CB-13685:
-------------------------------------
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1)
Report
> Merging
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/559b0833b42402a2b0fba6d6369fbc713e1063c1?src=pr&el=desc)
will **decrease** coverage by `3.79%`.
> The diff coverage is `66.92%`.
[](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #448 +/- ##
=========================================
- Coverage 47.63% 43.84% -3.8%
=========================================
Files 17 18 +1
Lines 1694 2023 +329
Branches 311 383 +72
=========================================
+ Hits 807 887 +80
- Misses 887 1136 +249
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
| `35.44% <40%> (+0.3%)` | :arrow_up: |
|
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
| `41.66% <68%> (ø)` | |
|
[bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==)
| `15.38% <0%> (-84.62%)` | :arrow_down: |
|
[bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=)
| `26.98% <0%> (-73.02%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer).
Last update
[559b083...22bb844](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> ----------------------
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
> Reporter: Josef Brandl
> Assignee: Joe Bowser
> Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
