[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608449#comment-16608449 ]
ASF GitHub Bot commented on CB-14166: ------------------------------------- raphinesse edited a comment on issue #688: CB-14166 distinguish npm.cmd and npm.exe in win32 to check escape necessary URL: https://github.com/apache/cordova-lib/pull/688#issuecomment-419712122 @knight9999 I see. I'd like to avoid a temporary quick fix, as they tend to stay around longer than initially planned :sweat_smile:. If it is urgent however, I guess we could include this in the next release **if** it is not properly fixed until then. > If your new PR is coming soon, it is no problem to skip this PR, I think. Actually I did not plan to do this myself, as I'm not regularly developing on Windows. I was hoping someone who was affected by this issue or at least someone usually working on Windows could do this. @knight9999, @oliversalzburg, @janpio. Volunteers anyone? Basically we only need to test [every user of `superspawn`](https://github.com/search?l=JavaScript&p=1&q=cordova-common+superspawn+user%3Aapache&type=Code) against the version at https://github.com/raphinesse/cordova-common/pull/1 :grin: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > ------------------------------------------- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Reporter: takuya > Assignee: Jesse MacFadyen > Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org