[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608353#comment-16608353
]
ASF GitHub Bot commented on CB-14166:
-------------------------------------
knight9999 edited a comment on issue #688: CB-14166 distinguish npm.cmd and
npm.exe in win32 to check escape necessary
URL: https://github.com/apache/cordova-lib/pull/688#issuecomment-419693168
In this PR, I used `which` module in order to check `npm` command, because
cordova-lib still uses cordova-fetch 1.x.
I feel that It is better to use `isNpmInstalled` function in the
cordova-fetch 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
