[ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981839#comment-14981839 ]
ASF GitHub Bot commented on DRILL-3232: --------------------------------------- Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/207#discussion_r43470768 --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java --- @@ -34,6 +34,13 @@ public static final MajorType REQUIRED_BIT = required(MinorType.BIT); public static final MajorType OPTIONAL_BIT = optional(MinorType.BIT); + public static boolean isUnion(MajorType toType) { + if (toType.getMinorType() == MinorType.UNION) { --- End diff -- probably better as return toType.getMinorType() == MinorType.UNION; > Modify existing vectors to allow type promotion > ----------------------------------------------- > > Key: DRILL-3232 > URL: https://issues.apache.org/jira/browse/DRILL-3232 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Codegen, Execution - Data Types, Execution - > Relational Operators, Functions - Drill > Reporter: Steven Phillips > Assignee: Hanifi Gunes > Fix For: 1.3.0 > > > Support the ability for existing vectors to be promoted similar to supported > implicit casting rules. > For example: > INT > DOUBLE > STRING > EMBEDDED -- This message was sent by Atlassian JIRA (v6.3.4#6332)