[ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981849#comment-14981849 ]
ASF GitHub Bot commented on DRILL-3232: --------------------------------------- Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/207#discussion_r43470982 --- Diff: exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java --- @@ -118,6 +119,9 @@ public void endField() throws IOException { } public static FieldConverter getConverter(RecordWriter recordWriter, int fieldId, String fieldName, FieldReader reader) { + if (reader instanceof UnionReader) { --- End diff -- why isn't this part of the case statement below (instead of instanceof)? > Modify existing vectors to allow type promotion > ----------------------------------------------- > > Key: DRILL-3232 > URL: https://issues.apache.org/jira/browse/DRILL-3232 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Codegen, Execution - Data Types, Execution - > Relational Operators, Functions - Drill > Reporter: Steven Phillips > Assignee: Hanifi Gunes > Fix For: 1.3.0 > > > Support the ability for existing vectors to be promoted similar to supported > implicit casting rules. > For example: > INT > DOUBLE > STRING > EMBEDDED -- This message was sent by Atlassian JIRA (v6.3.4#6332)