[
https://issues.apache.org/jira/browse/DRILL-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994838#comment-14994838
]
ASF GitHub Bot commented on DRILL-4047:
---------------------------------------
Github user julienledem commented on a diff in the pull request:
https://github.com/apache/drill/pull/246#discussion_r44204824
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -221,9 +603,46 @@ public void dropView(String viewName) throws
IOException {
return viewSet;
}
+ private Set<String> rawTableNames() {
+ return newHashSet(
+ transform(tables.keySet(), new
com.google.common.base.Function<TableInstance, String>() {
+ @Override
+ public String apply(TableInstance input) {
+ return input.sig.name;
+ }
+ }));
+ }
+
@Override
public Set<String> getTableNames() {
- return Sets.union(tables.keySet(), getViews());
+ System.out.println("getTableNames");
+ return Sets.union(rawTableNames(), getViews());
+ }
+
+ @Override
+ public Set<String> getFunctionNames() {
+ System.out.println("getFunctionNames");
+ return rawTableNames();
+ }
+
+ @Override
+ public List<Function> getFunctions(String name) {
+ System.out.println("getFunctions(" + name + ")");
+ List<TableSignature> sigs = optionExtractor.getTableSignatures(name);
+ System.out.println(sigs);
+// List<TableSignature> sigs = Arrays.asList(
+// new TableSignature(name, new TableParamDef("delimiter",
String.class, true)),
+// new TableSignature(name, new TableParamDef("delimiter",
Integer.TYPE, true)),
+// new TableSignature(name, new TableParamDef("foo",
Integer.TYPE, true), new TableParamDef("bar", Integer.TYPE, true)),
+// new TableSignature(name, new TableParamDef("foo",
String.class, true))
+// );
--- End diff --
todo:cleanup
> Select with options
> -------------------
>
> Key: DRILL-4047
> URL: https://issues.apache.org/jira/browse/DRILL-4047
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> Add a mechanism to pass parameters down to the StoragePlugin when writing a
> Select statement.
> Some discussion here:
> http://mail-archives.apache.org/mod_mbox/drill-dev/201510.mbox/%3CCAO%2Bvc4AcGK3%2B3QYvQV1-xPPdpG3Tc%2BfG%3D0xDGEUPrhd6ktHv5Q%40mail.gmail.com%3E
> http://mail-archives.apache.org/mod_mbox/drill-dev/201511.mbox/%3ccao+vc4clzylvjevisfjqtcyxb-zsmfy4bqrm-jhbidwzgqf...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
